[Flent-users] [tohojo/flent] packet loss stats (#106)

[Pete Heist]

> On Nov 20, 2017, at 9:58 PM, Toke Høiland-Jørgensen <notifications at github.com> wrote:
> Okay, testable code in the runner-refactor branch.
> 
> Ended up doing a fairly involved refactoring of how runners work with
> data; which is good, as the new way to structure things makes a lot more
> sense in general; but it did mean I had to change the data format, so
> quite a few places this can break. So testing appreciated, both for
> running new tests, and for plotting old data files.
> 
Awesome, I’m sure it could take some shaking out. I tried an rrul_be test on the runner-refactor branch...

```
% flent rrul_be --socket-stats -l 60 -H 10.72.0.231 -p all_scaled --figure-width=10 --figure-height=7.5 -t new_runner_test -o new_runner_test.png
Started Flent 1.1.1-git-b958d01 using Python 2.7.13.
Starting rrul_be test. Expected run time: 70 seconds.
Traceback (most recent call last):
  File "/usr/local/bin/flent", line 11, in <module>
    load_entry_point('flent===1.1.1-git-b958d01', 'console_scripts', 'flent')()
  File "/usr/local/lib/python2.7/dist-packages/flent-1.1.1_git_b958d01-py2.7.egg/flent/__init__.py", line 59, in run_flent
    b.run()
  File "/usr/local/lib/python2.7/dist-packages/flent-1.1.1_git_b958d01-py2.7.egg/flent/batch.py", line 609, in run
    return self.run_test(self.settings, self.settings.DATA_DIR, True)
  File "/usr/local/lib/python2.7/dist-packages/flent-1.1.1_git_b958d01-py2.7.egg/flent/batch.py", line 508, in run_test
    res = self.agg.postprocess(self.agg.aggregate(res))
  File "/usr/local/lib/python2.7/dist-packages/flent-1.1.1_git_b958d01-py2.7.egg/flent/aggregators.py", line 232, in aggregate
    measurements, metadata, raw_values = self.collect()
  File "/usr/local/lib/python2.7/dist-packages/flent-1.1.1_git_b958d01-py2.7.egg/flent/aggregators.py", line 120, in collect
    t.check()
  File "/usr/local/lib/python2.7/dist-packages/flent-1.1.1_git_b958d01-py2.7.egg/flent/runners.py", line 964, in check
    ip_version=args['ip_version'])
  File "/usr/local/lib/python2.7/dist-packages/flent-1.1.1_git_b958d01-py2.7.egg/flent/runners.py", line 232, in add_child
    c.check()
  File "/usr/local/lib/python2.7/dist-packages/flent-1.1.1_git_b958d01-py2.7.egg/flent/runners.py", line 1652, in check
    super(SsRunner, self).check()
  File "/usr/local/lib/python2.7/dist-packages/flent-1.1.1_git_b958d01-py2.7.egg/flent/runners.py", line 393, in check
    self.metadata['UNITS'] = self.units
AttributeError: 'SsRunner' object has no attribute 'units'
```

Without —socket-stats:

```
% flent rrul_be -l 60 -H 10.72.0.231 -p all_scaled --figure-width=10 --figure-height=7.5 -t new_runner_test -o new_runner_test.png
Started Flent 1.1.1-git-b958d01 using Python 2.7.13.
Starting rrul_be test. Expected run time: 70 seconds.
Traceback (most recent call last):
  File "/usr/local/bin/flent", line 11, in <module>
    load_entry_point('flent===1.1.1-git-b958d01', 'console_scripts', 'flent')()
  File "/usr/local/lib/python2.7/dist-packages/flent-1.1.1_git_b958d01-py2.7.egg/flent/__init__.py", line 59, in run_flent
    b.run()
  File "/usr/local/lib/python2.7/dist-packages/flent-1.1.1_git_b958d01-py2.7.egg/flent/batch.py", line 609, in run
    return self.run_test(self.settings, self.settings.DATA_DIR, True)
  File "/usr/local/lib/python2.7/dist-packages/flent-1.1.1_git_b958d01-py2.7.egg/flent/batch.py", line 508, in run_test
    res = self.agg.postprocess(self.agg.aggregate(res))
  File "/usr/local/lib/python2.7/dist-packages/flent-1.1.1_git_b958d01-py2.7.egg/flent/aggregators.py", line 232, in aggregate
    measurements, metadata, raw_values = self.collect()
  File "/usr/local/lib/python2.7/dist-packages/flent-1.1.1_git_b958d01-py2.7.egg/flent/aggregators.py", line 120, in collect
    t.check()
  File "/usr/local/lib/python2.7/dist-packages/flent-1.1.1_git_b958d01-py2.7.egg/flent/runners.py", line 1458, in check
    delay=self.delay, remote_host=self.remote_host,
AttributeError: 'UdpRttRunner' object has no attribute 'delay'

```



-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/issues/106#issuecomment-345945567
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://flent.org/pipermail/flent-users_flent.org/attachments/20171121/d3de7c4e/attachment-0002.html>